feat: customizable fill handle config #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces customizable fill handle configuration, allowing users to control the shape, size, position, and outline of the fill handle (the drag square in the bottom-right corner of a cell selection). The default behavior is maintained with a rectangular handle offset on the corner with an outline.
- Changes the
fillHandleprop from a boolean to accept either a boolean or a partial configuration object - Adds support for circular and square fill handle shapes with customizable size and positioning
- Updates rendering logic to draw the fill handle with configurable outline and positioning
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/internal/data-grid/data-grid-types.ts | Defines new FillHandleConfig type and DEFAULT_FILL_HANDLE constant |
| packages/core/src/internal/data-grid/render/draw-grid-arg.ts | Updates DrawGridArg interface to use FillHandle type instead of boolean |
| packages/core/src/internal/data-grid/render/data-grid.render.rings.ts | Implements new fill handle rendering logic with shape, size, and outline support |
| packages/core/src/internal/data-grid/render/data-grid-render.ts | Updates fill handle visibility check to work with new type |
| packages/core/src/internal/data-grid/data-grid.tsx | Updates mouse position detection logic for customizable fill handle dimensions |
| packages/core/src/docs/examples/fill-handle.stories.tsx | Updates example to demonstrate new configuration options |
| packages/core/API.md | Updates documentation to reflect new fillHandle configuration options |
packages/core/src/internal/data-grid/render/data-grid.render.rings.ts
Outdated
Show resolved
Hide resolved
packages/core/src/internal/data-grid/render/data-grid.render.rings.ts
Outdated
Show resolved
Hide resolved
|
Addressed copilot comments; fixing merge. |
lukasmasuch
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows fill handle to be customizable. Default is rectangle offset on the corner with outline.